Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: improve parseInvitation to handle parsing oob properly #280

Closed
wants to merge 1 commit into from
Closed

fix: improve parseInvitation to handle parsing oob properly #280

wants to merge 1 commit into from

Conversation

elribonazo
Copy link
Contributor

@elribonazo elribonazo commented Sep 2, 2024 •
edited
Loading

Description:

Improvement in order to keep SDK's aligned, we are able to use parseOOBInvitation with the URL object directly or the standard parseInvitation with the uri string + added test coverage

  1. agent.parseOOBInvitation(new URL(validOOB))
  2. agent.parseInvitation(validOOB) //as string

Checklist:

  • My PR follows the contribution guidelines of this project
  • My PR is free of third-party dependencies that don't comply with the Allowlist
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked the PR title to follow the conventional commit specification

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 2, 2024

Lines Statements Branches Functions
Coverage: 76%
 76.26% (2860/3750) 65.91% (1402/2127) 81.1% (734/905)

JUnit

Tests Skipped Failures Errors Time
528 6 💤 0 ❌ 0 🔥 55.675s ⏱️

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10664806424

Details

  • 28 of 33 (84.85%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 72.462%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/edge-agent/Agent.Invitations.ts 11 13 84.62%
src/edge-agent/protocols/invitation/v2/DIDCommInvitationRunner.ts 14 17 82.35%
Totals Coverage Status
Change from base Build 10662917238: 0.2%
Covered Lines: 2795
Relevant Lines: 3665
💛 - Coveralls

@elribonazo
fix: improve parseInvitation to handle parsing oob properly either wi…
1234b3b 
…th URL or with parsed object.

Signed-off-by: Francisco Javier Ribo Labrador <elribonazo@gmail.com>
@elribonazo elribonazo closed this Sep 16, 2024
@elribonazo
Copy link
Contributor Author

Closed as some parallel work is being led by @curtis-h

@elribonazo elribonazo deleted the feature/parse-invitation-fix branch September 16, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amagyar-iohk amagyar-iohk Awaiting requested review from amagyar-iohk amagyar-iohk is a code owner

@curtis-h curtis-h Awaiting requested review from curtis-h curtis-h is a code owner

@goncalo-frade-iohk goncalo-frade-iohk Awaiting requested review from goncalo-frade-iohk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elribonazo @coveralls